Skip to content

ci: ensure we don't push manifest list #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorah merged 2 commits into from
Feb 21, 2026
Merged

ci: ensure we don't push manifest list #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cac3ce
ci: roll newer deps
sorah Feb 21, 2026
410f9f7
ci: ensure we don't push manifest list
sorah Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ jobs:
name: pr
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: ruby/setup-ruby@09a7688d3b55cf0e976497ff046b70949eeaccfd # v1.288.0
with:
ruby-version: '3.2'
bundler-cache: true
- name: 'Build Docker image'
uses: 'docker/build-push-action@v3'
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
with:
context: '.'
load: true
Expand Down
33 changes: 24 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,29 @@ jobs:
id-token: write
runs-on: ubuntu-latest
outputs:
image-tag: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }}"
image-tag: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }}-amd64"
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: ruby/setup-ruby@09a7688d3b55cf0e976497ff046b70949eeaccfd # v1.288.0
with:
ruby-version: '3.4'
ruby-version: '4.0'
bundler-cache: true
- uses: aws-actions/configure-aws-credentials@v4
- uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-region: "us-west-2"
role-skip-session-tagging: true
role-to-assume: "arn:aws:iam::005216166247:role/GhaRkoRouterDeploy"
mask-aws-account-id: 'false' # only string works
- id: login-ecr
uses: aws-actions/amazon-ecr-login@v2
uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
- name: 'Build Docker image'
uses: 'docker/build-push-action@v3'
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
with:
context: '.'
load: true
tags: "rko-router-test:latest,${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }},${{ steps.login-ecr.outputs.registry }}/rko-router:latest"
cache-from: type=gha
cache-to: type=gha,mode=max
- name: 'Start container for test'
run: |
set -x
Expand All @@ -52,11 +54,24 @@ jobs:
export TARGET_HOST="http://$(docker port rko-router-dut 8080)"
bundle exec rspec -fd || ( docker logs rko-router-dut; false )
- name: 'Push Docker image'
uses: 'docker/build-push-action@v5'
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
with:
context: '.'
push: true
tags: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }},${{ steps.login-ecr.outputs.registry }}/rko-router:latest"
cache-from: type=gha
cache-to: type=gha,mode=max
- name: 'Push Docker image'
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
with:
context: '.'
push: true
tags: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }}-amd64"
cache-from: type=gha
cache-to: type=gha,mode=max
# Lambda does not support manifest list
sbom: false
provenance: false

deploy-lambda:
name: deploy-lambda
Expand All @@ -73,7 +88,7 @@ jobs:
needs:
- ci
steps:
- uses: aws-actions/configure-aws-credentials@v4
- uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
with:
aws-region: "us-west-2"
role-skip-session-tagging: true
Expand Down
Loading