Disable bombing on finihed game

Author: cveneziani

app/assets/javascripts/battletype/logs.js

@@ -32,6 +32,7 @@
     },
     "bomb": {
       "attacked_player_ship": "You tried to bomb your mothership!!",
+      "not_running":          "Game is not running!",
       "ship_not_found":       "Ship to bomb not found"
     },
     "defense": {

app/dispatches/bombs/drop.rb

@@ -46,10 +46,14 @@ def failed_payloads
         code:         'failed_bombing',
         player_id:    player.id,
         word:         word,
-        error_codes:  bomb.errors[:word]
+        error_codes:  error_codes
       }]
     end
 
+    def error_codes
+      bomb.errors.messages.values.flatten
+    end
+
     def game_won?
       attacked_player.life == 0
     end

app/models/bomb.rb

@@ -1,7 +1,7 @@
 class Bomb
   include ActiveModel::Validations
 
-  validate :ship_exists, :not_matching_attacked_player_ship
+  validate :game_running, :ship_exists, :not_matching_attacked_player_ship
 
   private
   attr_reader :player, :word
@@ -18,6 +18,12 @@ def ship
 
   private
 
+  def game_running
+    unless player.game.state == 'running'
+      errors.add(:game, "not_running")
+    end
+  end
+
   def not_matching_attacked_player_ship
     matching = ships.where.not(player_id: player.id).where(words: { value: word }).exists?
 

spec/dispatches/bombs/drop_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "Bombs::Drop", type: :dispatch do
   subject(:dispatch)    { Bombs::Drop }
 
-  let(:game)            { Game.create! }
+  let(:game)            { Game.create!(state: 'running') }
   let(:attacked_player) { Player.create!(game: game, life: 10) }
   let(:attacked_word)   { Word.create!(game: game, value: 'go') }
   let(:attacker)        { Player.create!(game: game) }

spec/models/bomb_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "Bomb", type: :model do
   subject(:bomb) { Bomb.new(player: attacker, word: word) }
 
-  let(:game)            { Game.create! }
+  let(:game)            { Game.create!(state: 'running') }
   let(:attacker)        { Player.create!(game: game) }
   let(:attacker_word)   { Word.create!(value: 'BOMB', game: game) }
   let(:perfect_typing)  { '1' }
@@ -66,5 +66,17 @@
         expect(bomb.valid?).to eq(true)
       end
     end
+
+    context "when game is finished" do
+      let(:word) { 'BOMB' }
+
+      before :each do
+        game.update(state: 'finished')
+      end
+
+      it 'returns false' do
+        expect(bomb.valid?).to eq(false)
+      end
+    end
   end
 end

spec/requests/bombings_spec.rb

@@ -1,8 +1,7 @@
 require "rails_helper"
 
 RSpec.describe "Bombings", type: :request do
-  let(:game)            { Game.create!(name: 'Starship Battle') }
-  let(:game)            { Game.create! }
+  let(:game)            { Game.create!(name: 'Starship Battle', state: 'running') }
   let(:attacked_player) { Player.create!(game: game, life: 10) }
   let(:attacked_word)   { Word.create!(game: game, value: 'go') }
   let(:attacker)        { Player.create!(game: game, life: 7) }
@@ -168,5 +167,31 @@
         )
       end
     end
+
+    context "when game is finished" do
+      before :each do
+        game.update(state: 'finished')
+      end
+
+      it "returns 200 HTTP status" do
+        post "/bombings", params: { word: 'BOMB' }
+        expect(response).to have_http_status(200)
+      end
+
+      it 'broadcasts a failed bombing payload' do
+        allow(ActionCable.server).to receive(:broadcast)
+        post "/bombings", params: { word: 'BOMB' }
+
+        expect(ActionCable.server).to have_received(:broadcast).with(
+          anything,
+          {
+            code:         'failed_bombing',
+            player_id:    attacker.id,
+            word:         'BOMB',
+            error_codes:  ['not_running']
+          }
+        )
+      end
+    end
   end
 end