Disable attack on finished game

Author: cveneziani

app/assets/javascripts/battletype/logs.js

@@ -27,6 +27,7 @@
     "attack": {
       "english_word":                 "Must be an English word",
       "long_enough":                  "Word is not long enough",
+      "not_running":                  "Game is not running!",
       "unique_case_insensitive_word": "Word must be unique"
     },
     "bomb": {

app/dispatches/attacks/launch.rb

@@ -28,7 +28,11 @@ def call
     private
 
     def failed_payload
-      { code: 'failed_attack', player_id: player.id, word: word, error_codes: attack.errors[:word] }
+      { code: 'failed_attack', player_id: player.id, word: word, error_codes: error_codes }
+    end
+
+    def error_codes
+      attack.errors.messages.values.flatten
     end
 
     def save_word

app/models/attack.rb

@@ -2,7 +2,7 @@ class Attack
   include ActiveModel::Validations
   MIN_WORD_SIZE = 2
 
-  validate :unique_case_insensitive_word?, :english_word?, :long_enough?
+  validate :game_running?, :unique_case_insensitive_word?, :english_word?, :long_enough?
 
   private
   attr_reader :game, :word, :player
@@ -30,6 +30,12 @@ def initialize(game:, word:, player:)
 
   private
 
+  def game_running?
+    unless game.state == 'running'
+      errors.add(:game, "not_running")
+    end
+  end
+
   def unique_case_insensitive_word?
     unless Word.where(game: game).where('LOWER(value) = LOWER(?)', word).empty?
       errors.add(:word, "unique_case_insensitive_word")

spec/dispatches/attacks/launch_spec.rb

@@ -2,13 +2,16 @@
 
 RSpec.describe "Attacks::Launch", type: :dispatch do
   subject(:dispatch)  { Attacks::Launch }
-  let(:game)          { Game.create! }
+  let(:game)          { Game.create!(state: 'running') }
   let(:player)        { Player.create!(game: game, nickname: "Rico") }
 
   describe ".call" do
     context 'when word is valid' do
       let(:word) { 'curry' }
-      before { allow_words(word) }
+
+      before :each do
+        allow_words(word)
+      end
 
       it 'saves the Word' do
         expect { dispatch.call(player: player, word: word) }.to change { Word.where(value: word, game: game).count }.from(0).to(1)
@@ -64,6 +67,7 @@
       let(:word) { 'duplicate' }
 
       before :each do
+        allow_words(word)
         Word.create!(game: game, value: word)
       end
 
@@ -82,7 +86,7 @@
       end
 
       it "returns a payload with the invalid word and the attacker's id" do
-        expect(dispatch.call(player: player, word: word)).to include(code: 'failed_attack', word: "duplicate", player_id: player.id, error_codes: ["unique_case_insensitive_word", "english_word"])
+        expect(dispatch.call(player: player, word: word)).to include(code: 'failed_attack', word: "duplicate", player_id: player.id, error_codes: ["unique_case_insensitive_word"])
       end
     end
   end

spec/models/attack_spec.rb

@@ -2,9 +2,10 @@
 
 RSpec.describe "Attack", type: :model do
   subject(:attack)  { Attack.new(game: game, word: word, player: player) }
-  let(:game)        { Game.create! }
+  let(:game)        { Game.create!(state: 'running') }
   let(:word)        { 'attack' }
   let(:player)      { Player.new }
+
   before { allow_words("attack") }
 
   describe '.reward_for' do
@@ -97,5 +98,16 @@
       it { expect(Attack.new(game: game, word: "AniMal", player: player).valid?).to be true }
       it { expect(Attack.new(game: game, word: "animal12", player: player).valid?).to be false }
     end
+
+    context 'when game is finished' do
+      before :each do
+        allow_words("finished")
+        game.update(state: 'finished')
+      end
+
+      it 'returns false' do
+        expect(attack.valid?).to eq(false)
+      end
+    end
   end
 end

spec/requests/attacks_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe "Attacks", type: :request do
-  let(:game)            { Game.create!(name: 'Starship Battle') }
+  let(:game)            { Game.create!(name: 'Starship Battle', state: 'running') }
   let(:player)          { game.players.create!(nickname: "Rico") }
 
   before :each do
@@ -54,6 +54,7 @@
 
     context 'when provided word has already been played with a different case' do
       before :each do
+        allow_words("battletype")
         game.words.create!(value: 'BattleType')
       end
 
@@ -65,7 +66,25 @@
       it 'broadcasts an error message' do
         allow(ActionCable.server).to receive(:broadcast)
         post "/attacks", params: { word: 'battletype' }
-        expect(ActionCable.server).to have_received(:broadcast).with(anything, code: 'failed_attack', player_id: player.id, word: 'battletype', error_codes: ["unique_case_insensitive_word", "english_word"])
+        expect(ActionCable.server).to have_received(:broadcast).with(anything, code: 'failed_attack', player_id: player.id, word: 'battletype', error_codes: ["unique_case_insensitive_word"])
+      end
+    end
+
+    context 'when game is finished' do
+      before :each do
+        allow_words("finished")
+        game.update(state: 'finished')
+      end
+
+      it 'returns 200 HTTP status' do
+        post "/attacks", params: { word: 'finished' }
+        expect(response).to have_http_status(200)
+      end
+
+      it 'broadcasts an error message' do
+        allow(ActionCable.server).to receive(:broadcast)
+        post "/attacks", params: { word: 'finished' }
+        expect(ActionCable.server).to have_received(:broadcast).with(anything, code: 'failed_attack', word: 'finished', player_id: player.id, error_codes: ['not_running'] )
       end
     end
   end