Merge pull request #92 from ruby-nord/bug/game-finished

Fix game finished results

Author: cveneziani

app/models/game.rb

@@ -7,6 +7,9 @@ class Game < ApplicationRecord
   has_many :ships,   through: :players
   has_many :words,   dependent: :destroy
 
+  has_one :loser,  -> { where(won: false ) }, class_name: 'Player'
+  has_one :winner, -> { where(won: true ) },  class_name: 'Player'
+
   def to_param
     slug
   end

app/views/games/finished.html.erb

@@ -9,13 +9,14 @@
       </div>
     </div>
     <div class="too_late">
-      <% if @game.players.include?(current_player) && current_player.won == false %>
+      <% case current_player
+         when @game.winner %>
         <h1>Game Finished, Congratulations! You WON!</h1>
         <p>
           You're the master of the <strong><%= @game.name %></strong> room
           where you defeated <strong><%= @opponent.nickname %></strong>.
         </p>
-      <% elsif @game.players.include?(current_player) %>
+      <% when @game.loser %>
         <h1>Game Finished, You LOSE!</h1>
         <p>
           Today wasn't a good day for you in the <strong><%= @game.name %></strong> room.
@@ -29,7 +30,8 @@
           <strong><%= @game.players.last.nickname %></strong> had an epic fight deep in the space.
         </p>
       <% end %>
-        <p>In total, the battle involved <strong><%= @game.ships.count %> ships</strong> and <strong><%= @game.ships.sum(:damage) %> damages</strong>.</p>
+
+      <p>In total, the battle involved <strong><%= @game.ships.count %> ships</strong> and <strong><%= @game.ships.sum(:damage) %> damages</strong>.</p>
 
       <%= render 'components/social_links' %>
     </div>

spec/models/game_spec.rb

@@ -0,0 +1,8 @@
+require "rails_helper"
+
+RSpec.describe "Game", type: :model do
+  subject(:game) { Game.new }
+
+  it { is_expected.to have_one(:loser).class_name(Player).conditions(won: false) }
+  it { is_expected.to have_one(:winner).class_name(Player).conditions(won: true) }
+end

spec/requests/games_spec.rb

@@ -4,7 +4,7 @@
   let(:game) { Game.create!(name: 'Starship Battle', slug: 'starship-battle') }
 
   describe "GET show" do
-    context "url is not parametrized" do
+    context "url is not parameterized" do
       before :each do
         get URI::encode("/games/#{game.name}")
       end
@@ -107,15 +107,42 @@
     end
 
     context "when game is finished" do
+      let(:rico)  { Player.create!(nickname: "Rico") }
+      let(:zim)   { Player.create!(nickname: "Zim") }
+
       before :each do
         game.update(state: "finished")
-        Player.create!(nickname: "Zim", game: game)
-        Player.create!(nickname: "Rico", game: game, won: true)
 
+        rico.update!(game: game, won: true)
+        zim.update!(game: game, won: false)
+      end
+
+      it 'tells that the game is finished' do
         get "/games/#{game.to_param}"
+        expect(response.body).to include("finished")
+      end
+
+      context 'when the signed-in player won the game' do
+        before :each do
+          allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(rico)
+        end
+
+        it 'tells the user that he won' do
+          get "/games/#{game.to_param}"
+          expect(response.body).to include("WON")
+        end
       end
 
-      it { expect(response.body).to include("finished") }
+      context 'when the signed-in player lost the game' do
+        before :each do
+          allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(zim)
+        end
+
+        it 'tells the user that he lost' do
+          get "/games/#{game.to_param}"
+          expect(response.body).to include("LOSE")
+        end
+      end
     end
   end