Skip to content

Fix self-reference in NA_MD_LOOP for Windows Ruby 3.4 / Fedra43 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kojix2 wants to merge 3 commits into from
Closed

Fix self-reference in NA_MD_LOOP for Windows Ruby 3.4 / Fedra43 #228

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2167636
Update GitHub Actions workflow
kojix2 May 24, 2025
fa505bd
Fix function pointer declaration
kojix2 May 24, 2025
0b794a1
Remove redundant typedef and fix self-reference in NA_MD_LOOP
kojix2 May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ on: [push, pull_request]
jobs:
MRI:
name: ${{ matrix.os }} ruby-${{ matrix.ruby }}
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os }}-latest
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-11, windows-2022]
ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', head]
include:
- { os: windows-2022 , ruby: mswin }
os: ['ubuntu', 'macos', 'windows']
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3', '3.4', head]
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby }}
Expand Down
4 changes: 3 additions & 1 deletion ext/numo/narray/ndloop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ typedef struct NA_LOOP_XARGS {
bool free_user_iter; // alloc LARG(lp,j).iter=lp->xargs[j].iter
} na_loop_xargs_t;

typedef struct NA_MD_LOOP na_md_loop_t;

typedef struct NA_MD_LOOP {
int narg;
int nin;
Expand All @@ -56,7 +58,7 @@ typedef struct NA_MD_LOOP {
VALUE reduce;
VALUE loop_opt;
ndfunc_t *ndfunc;
void (*loop_func)();
void (*loop_func)(ndfunc_t *, na_md_loop_t *);
} na_md_loop_t;

#define LARG(lp,iarg) ((lp)->user.args[iarg])
Expand Down
Loading