Fix integration tests by updating aws-sdk-sqs and replacing moto#783
Merged
Fix integration tests by updating aws-sdk-sqs and replacing moto#783
Conversation
… LocalStack (#782) * Increase timeout in integration tests to fix flaky failures * Provide an xml parser engine for aws sdk core version 2 * update aws-sdk-sqs * Remove queue cleanup in integration tests as moto/localstack handle it automatically * Replace moto with LocalStack in integration tests * Replace moto with LocalStack in integration tests * Fix LocalStack service configuration in GitHub Actions
…ken/shoryuken into replace-moto-with-localstack
Contributor
Collaborator
Author
|
@myumura great. Let me reflect this in the gemspec then 🙏 |
Collaborator
Author
|
@phstc, would you mind removing those from the CI requirement? Remaining once are 💚
|
phstc
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #782
alongside of changes by @myumura this PR also:
aws-sdk-sqsto the lowest version possible to work with localstack