Skip to content

Add checked classes for COMBOBOX + RADIO_BUTTON #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

Add checked classes for COMBOBOX + RADIO_BUTTON #305

merged 2 commits into from
Jul 1, 2025

Conversation

pierry01
Copy link
Contributor

@pierry01 pierry01 commented Jul 1, 2025 •
edited
Loading

It is necessary to respect the primary color here

CHECKBOX
image
image

RADIO_BUTTON
image
image

@pierry01 pierry01 marked this pull request as ready for review July 1, 2025 18:24
@pierry01 pierry01 requested review from cirdes and stephannv as code owners July 1, 2025 18:24
stephannLKN
stephannLKN approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@stephannLKN stephannLKN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the RubyUI::ComboboxRadio need some adjustment?

@pierry01
Copy link
Contributor Author

pierry01 commented Jul 1, 2025

RubyUI::ComboboxRadio

Yes, it will, well remembered!

@pierry01 pierry01 force-pushed the jean/checked-classes branch from 2564d51 to 5a88ba4 Compare July 1, 2025 18:32
cirdes
cirdes approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@cirdes cirdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@cirdes cirdes merged commit 8beff01 into ruby-ui:main Jul 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirdes cirdes cirdes approved these changes

@stephannv stephannv Awaiting requested review from stephannv stephannv is a code owner

+1 more reviewer

@stephannLKN stephannLKN stephannLKN approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierry01 @cirdes @stephannLKN