Skip to content

Implement to_d in Numeric and with the same number of arguments everywhere #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement to_d in Numeric and with the same number of arguments everywhere #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 10 additions & 55 deletions lib/bigdecimal/util.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,13 @@

require 'bigdecimal'

class Integer < Numeric
class Numeric
# call-seq:
# int.to_d -> bigdecimal
# num.to_d -> bigdecimal
# num.to_d(precision) -> bigdecimal
#
# Returns the value of +int+ as a BigDecimal.
#
# require 'bigdecimal'
# require 'bigdecimal/util'
#
# 42.to_d # => 0.42e2
#
# See also Kernel.BigDecimal.
#
def to_d
BigDecimal(self)
end
end


class Float < Numeric
# call-seq:
# float.to_d -> bigdecimal
# float.to_d(precision) -> bigdecimal
# Returns the value as a BigDecimal.
#
# Returns the value of +float+ as a BigDecimal.
# The +precision+ parameter is used to determine the number of
# significant digits for the result. When +precision+ is set to +0+,
# the number of digits to represent the float being converted is determined
Expand All @@ -41,18 +23,16 @@ class Float < Numeric
# require 'bigdecimal'
# require 'bigdecimal/util'
#
# 0.5.to_d # => 0.5e0
# 1.234.to_d # => 0.1234e1
# 1.234.to_d(2) # => 0.12e1
# Rational(22, 7).to_d(3) # => 0.314e1
# 3.14.to_d(3) # => 0.314e1
# 3.to_d(3) # => 0.3e1
#
# See also Kernel.BigDecimal.
#
def to_d(precision=0)
BigDecimal(self, precision)
end
end


class String
# call-seq:
# str.to_d -> bigdecimal
Expand Down Expand Up @@ -108,32 +88,7 @@ def to_digits
# d.to_d # => 0.314e1
#
def to_d
self
end
end


class Rational < Numeric
# call-seq:
# rat.to_d(precision) -> bigdecimal
#
# Returns the value as a BigDecimal.
#
# The +precision+ parameter is used to determine the number of
# significant digits for the result. When +precision+ is set to +0+,
# the number of digits to represent the float being converted is determined
# automatically.
# The default +precision+ is +0+.
#
# require 'bigdecimal'
# require 'bigdecimal/util'
#
# Rational(22, 7).to_d(3) # => 0.314e1
#
# See also Kernel.BigDecimal.
#
def to_d(precision=0)
BigDecimal(self, precision)
self # override to return the same object
end
end

Expand Down Expand Up @@ -180,7 +135,7 @@ class NilClass
#
# nil.to_d # => 0.0
#
def to_d
BigDecimal(0)
def to_d(precision=0)
BigDecimal(0, precision)
end
end
Loading