Skip to content

Fix "ORDER BY" #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix "ORDER BY" #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fede64
Fix "ORDER BY"
kzys Oct 10, 2024
f302e9c
The default is too low
kzys Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ Metrics/BlockLength:

Metrics/MethodLength:
Max: 40

Metrics/AbcSize:
Max: 50
5 changes: 3 additions & 2 deletions app/controllers/messages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ def index
# %> and <-> are defined by pg_trgm.
# https://www.postgresql.org/docs/17/pgtrgm.html
message_where = if Rails.env.production?
Message.where('body %> ? AND list_id IN (?) ORDER BY body <-> ?', query, list_ids, query)
Message.where('body %> ? AND list_id IN (?)', query, list_ids)
.order(Arel.sql('body <-> ?', query))
else
Message.where('body LIKE ? AND list_id IN (?)', "%#{query}%", list_ids)
end
Expand All @@ -36,7 +37,7 @@ def show
def get_list_ids(params)
list_ids = []
['ruby-talk', 'ruby-core', 'ruby-list', 'ruby-dev'].each do |name|
if params[name.tr('-', '_').to_sym] == '1'
if params[name.tr('-', '_').to_sym] != '0'
list_ids << List.find_by_name(name).id
end
end
Expand Down