-
Notifications
You must be signed in to change notification settings - Fork 350
Java Extension Optimizations #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samyron
wants to merge
4
commits into
ruby:master
Choose a base branch
from
samyron:sm/use-segmented-outputstream-and-swar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Java Extension Optimizations #835
samyron
wants to merge
4
commits into
ruby:master
from
samyron:sm/use-segmented-outputstream-and-swar
+235
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samyron
commented
Aug 13, 2025
java/src/json/ext/LinkedSegmentedByteListDirectOutputStream.java
Outdated
Show resolved
Hide resolved
samyron
commented
Aug 13, 2025
private static final int DEFAULT_CAPACITY = 1024; | ||
|
||
private int totalLength; | ||
private byte[][] segments = new byte[21][]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 21
? The minimum segment size is 1024
for the first segment. The code doubles the segment size for each additional segment. Based on this doubling, we only need 21 segments before we hit Integer.MAX_VALUE
.
…SegmentedByteListDirectOutputStream.
…ing the output buffer.
Synthetic benchmarks of encoding an array of 128-byte ASCII strings.
SegmetedByteListDirectOutputStream + SWAR
ByteListDirectOutputStream + Scalar (effectively the same code as master)
SegmentedByteListDirectOutputStream + Scalar
ByteListDirectOutputStream + SWAR
Master
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog 📓
OutputStream
to reduceSystem.arraycopy
's each time the output buffer is resized.StringEncoder#encode
to include a SWAR-based fast path for basic JSON encoding. The algorithm is from this post. It's the same as the vector-based algorithm in the C extension.These features can be toggled with the system properties
json.useSegmentedOutputStream
andjson.useSWARBasicEncoder
. Both default totrue
. I'm happy to remove these. They made testing and benchmarking much easier.Benchmarks
SegmentedByteListDirectOutputStream + SWAR
ByteListDirectOutputStream + SWAR
ByteListDirectOutputStream + Scalar
SegmentedByteListDirectOutputStream + Scalar
master (as of commit 37e6890)