Centralize macro definitions #889
Merged
+108
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
force-pushed
the
cleanup-macros
branch
from
96a8e34 to
b87b445
Compare
byroot
force-pushed
the
cleanup-macros
branch
from
b87b445 to
1576ea7
Compare
Member
|
@byroot This seems to have failed the ruby/ruby CI https://github.com/ruby/ruby/actions/runs/19029707129/job/54340559941. Could you have a look at fixing it? |
Member
Author
|
Looking. |
byroot
added a commit
that referenced
this pull request
Nov 3, 2025
Member
Author
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 3, 2025
Member
|
Thanks for looking at it, but it didn't fix the CI: https://github.com/ruby/ruby/actions/runs/19040691293/job/54376769963 |
Member
|
Sorry, you've already pushed another fix 3bc1787bd4. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.