C Extension: Use #if instead of #ifdef for JSON_DEBUG #896
+10
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling the C extension, I kept hitting code within the
#ifdef JSON_DEBUG. Using#ifdefchecks if the identifier is defined, not the value.I did not have the
JSON_DEBUGenvironment variable set but noticed the following injson.h:Adding
#error "RUBY_DEBUG defined but not JSON_DEBUG"after the#ifndefand runningrakeoutputs the following:I should note that I am not running debug build of Ruby. Adding a
printf("RUBY_DEBUG=%lu\n", RUBY_DEBUG);outputs a lot ofRUBY_DEBUG=0.My assumption is we want this code to be excluded if JSON_DEBUG is 0.