♻️ Move FETCH msg-att response parser tests to yaml

BODY/BODYSTRUCTURE is very complicated and often buggy [requiring many
workarounds and tests), so it's kept in its own file.

Author: nevans

test/net/imap/fixtures/response_parser/fetch_responses.yml

@@ -0,0 +1,76 @@
+---
+:tests:
+  test_fetch_msg_att_uid:
+    :response: "* 1 FETCH (UID 92285)\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: FETCH
+      data: !ruby/struct:Net::IMAP::FetchData
+        seqno: 1
+        attr:
+          UID: 92285
+      raw_data: "* 1 FETCH (UID 92285)\r\n"
+
+  test_fetch_msg_att_flags_and_uid:
+    :response: "* 1 FETCH (FLAGS (\\Seen $MDNSent \\Flagged Custom) UID 5)\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: FETCH
+      data: !ruby/struct:Net::IMAP::FetchData
+        seqno: 1
+        attr:
+          FLAGS:
+          - :Seen
+          - "$MDNSent"
+          - :Flagged
+          - Custom
+          UID: 5
+      raw_data: "* 1 FETCH (FLAGS (\\Seen $MDNSent \\Flagged Custom) UID 5)\r\n"
+
+  test_invalid_fetch_msg_att_extra_space:
+    :response: "* 1 FETCH (UID 92285 )\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: FETCH
+      data: !ruby/struct:Net::IMAP::FetchData
+        seqno: 1
+        attr:
+          UID: 92285
+      raw_data: "* 1 FETCH (UID 92285 )\r\n"
+
+  test_fetch_msg_att_modseq:
+    :comments: |
+      [Bug #10119]
+    :response: "* 1 FETCH (FLAGS (Seen) MODSEQ (12345) UID 5)\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: FETCH
+      data: !ruby/struct:Net::IMAP::FetchData
+        seqno: 1
+        attr:
+          FLAGS:
+          - Seen
+          MODSEQ: 12345
+          UID: 5
+      raw_data: "* 1 FETCH (FLAGS (Seen) MODSEQ (12345) UID 5)\r\n"
+
+  test_fetch_msg_att_rfc822:
+    :response: "* 123 FETCH (RFC822 {5}\r\nfoo\r\n)\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: FETCH
+      data: !ruby/struct:Net::IMAP::FetchData
+        seqno: 123
+        attr:
+          RFC822: "foo\r\n"
+      raw_data: "* 123 FETCH (RFC822 {5}\r\nfoo\r\n)\r\n"
+
+  test_invalid_fetch_msg_att_rfc822_with_brackets:
+    :response: "* 123 FETCH (RFC822[] {5}\r\nfoo\r\n)\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: FETCH
+      data: !ruby/struct:Net::IMAP::FetchData
+        seqno: 123
+        attr:
+          RFC822: "foo\r\n"
+      raw_data: "* 123 FETCH (RFC822[] {5}\r\nfoo\r\n)\r\n"
+
+  test_invalid_fetch_msg_att_unknown_fails:
+    :test_type: :assert_parse_failure
+    :response: "* 123 FETCH (UNKNOWN 92285)\r\n"
+    :message: !ruby/regexp / for \{123\}/

test/net/imap/test_imap_response_parser.rb

@@ -39,6 +39,9 @@ def teardown
   # RFC3501 §7.2.5: SEARCH response (obsolete in IMAP4rev2):
   generate_tests_from fixture_file: "search_responses.yml"
 
+  # §7.5.2: FETCH response, misc msg-att
+  generate_tests_from fixture_file: "fetch_responses.yml"
+
   # §7.5.2: FETCH response, BODYSTRUCTURE msg-att
   generate_tests_from fixture_file: "body_structure_responses.yml"
 
@@ -81,50 +84,6 @@ def test_flag_xlist_inbox
     assert_equal [:Inbox], response.data.attr
   end
 
-  def test_msg_att_extra_space
-    parser = Net::IMAP::ResponseParser.new
-    response = parser.parse(<<EOF.gsub(/\n/, "\r\n"))
-* 1 FETCH (UID 92285)
-EOF
-    assert_equal 92285, response.data.attr["UID"]
-
-    response = parser.parse(<<EOF.gsub(/\n/, "\r\n"))
-* 1 FETCH (UID 92285 )
-EOF
-    assert_equal 92285, response.data.attr["UID"]
-  end
-
-  def test_msg_att_parse_error
-    parser = Net::IMAP::ResponseParser.new
-    e = assert_raise(Net::IMAP::ResponseParseError) {
-      parser.parse(<<EOF.gsub(/\n/, "\r\n"))
-* 123 FETCH (UNKNOWN 92285)
-EOF
-    }
-    assert_match(/ for \{123\}/, e.message)
-  end
-
-  def test_msg_att_rfc822_text
-    parser = Net::IMAP::ResponseParser.new
-    response = parser.parse(<<EOF.gsub(/\n/, "\r\n"))
-* 123 FETCH (RFC822 {5}
-foo
-)
-EOF
-    assert_equal("foo\r\n", response.data.attr["RFC822"])
-    response = parser.parse(<<EOF.gsub(/\n/, "\r\n"))
-* 123 FETCH (RFC822[] {5}
-foo
-)
-EOF
-    assert_equal("foo\r\n", response.data.attr["RFC822"])
-  end
-
-  def assert_parseable(s)
-    parser = Net::IMAP::ResponseParser.new
-    parser.parse(s.gsub(/\n/, "\r\n"))
-  end
-
   def test_enable
     parser = Net::IMAP::ResponseParser.new
     response = parser.parse("* ENABLED SMTPUTF8\r\n")
@@ -146,13 +105,6 @@ def test_status
     assert_equal(1234, response.data.attr["UIDVALIDITY"])
   end
 
-  # [Bug #10119]
-  def test_msg_att_modseq_data
-    parser = Net::IMAP::ResponseParser.new
-    response = parser.parse("* 1 FETCH (FLAGS (\Seen) MODSEQ (12345) UID 5)\r\n")
-    assert_equal(12345, response.data.attr["MODSEQ"])
-  end
-
   def test_continuation_request_without_response_text
     parser = Net::IMAP::ResponseParser.new
     response = parser.parse("+\r\n")