Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 6, 2025

Bumps ffi from 1.16.3 to 1.17.1.

Changelog

Sourced from ffi's changelog.

1.17.1 / 2024-12-30

Fixed:

  • #1117 Restart async callback dispatcher thread after fork.
  • #1133 Add ruby-3.4 native gem.
  • #1134 Fix FFI::DataConverter non-generic usage in RBS files.

1.17.0 / 2024-06-02

Fixed:

  • Add FFI::AbstractMemory#read_array_of_string . It was defined but not exposed to Ruby nor tested. #1070

1.17.0.rc2 / 2024-04-22

Fixed:

  • Add missing write barriers to StructLayout#initialize causing a segfault with GC.stress. #1079

1.17.0.rc1 / 2024-04-08

Fixed:

  • Fix type definitions on aarch64-linux. #1067, #1066
  • Use RB_TEST for Pointer.autorelease= . #1065 So that false and nil are treated as falsey and anything else as truthy.
  • Replace Fixnum by Integer. #1064 Fixnum is no longer present in the ruby language.
  • Update FFI::NativeType doc. #1061
  • Store FFI::Type::Mapped of FFI::StrPtrConverter in global instead of custom type map
  • Various documentation fixes. #1042
  • Update FFI::Pointer#== to return false if a pointer is compared to a non-pointer object, which is the expected behavior. #1083
  • Avoid warning about undefined wariable @ffi_functions #1085
  • Fix a very unlikely GC bug when using a callback block. # 1089

Added:

  • Provide binary gems for many platforms. #990
  • Add Windows fat binary gem for Ruby-3.3
  • Add RBS type definitions for many user facing parts of the FFI API. #1042
  • Improve fallback search path logic. #1088 Respect LD_LIBRARY_PATH and DYLD_LIBRARY_PATH on Macos.
  • Update libffi to current git master branch.

Removed:

  • Remove enum CHAR_ARRAY which is no longer used. #1063
Commits
  • 9957408 Bump VERSION to 1.17.1
  • ec2e2b8 Add release notes for ffi-1.17.1
  • 278e45d Fix FFI::DataConverter non-generic usage
  • c960f4f Merge pull request #1133 from larskanis/ruby-3.4
  • 35e64d2 CI: Add ruby-3.4 to test matrix
  • eabf842 Add ruby-3.4 native gem
  • c128ced Merge pull request #1125 from voxik/closures-vs-fork-on-ppc64le-s390x-2
  • dc07b6e Some platforms don't support fork()
  • f9f19cc Ensure GC-ing closures before fork
  • 8e2c9cf Merge pull request #1123 from larskanis/fix-va_start
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 6, 2025
@dependabot dependabot bot force-pushed the dependabot/bundler/gemfiles/2.7/ffi-1.17.1 branch from 8571db8 to fb7258c Compare January 6, 2025 17:48
@tenderlove
Copy link
Member

Seems like the CI is failing because of RubyGems versions? I don't really understand why the binary version of the gem cares what version of RubyGems the target system uses.

@eregon
Copy link
Member

eregon commented Jan 7, 2025

cc @larskanis any idea why?

@larskanis
Copy link

It's because of ffi-1.17 is provided as native binary gems with a -musl and a -gnu version (the gnu version segfaults on musl otherwise) and because the older rubygems versions are too buggy to support these additions. The rubygems version check was introduced in rake-compiler/rake-compiler#236 and is described in here in more detail: https://github.com/rake-compiler/rake-compiler-dock?tab=readme-ov-file#linux-gnu-and-musl-important-details

The usual fix in to update rubygems or to use gem "ffi", force_ruby_platform: true as a workaround.

@eregon
Copy link
Member

eregon commented Jan 8, 2025

Thanks. I wonder if these 2 ruby 2.7 jobs need FFI at all, probably not since AFAIK it's only used for the FFI backend.
So maybe a good solution is to only include ffi in the Gemfile on Ruby >= 3.0.

@tenderlove
Copy link
Member

So maybe a good solution is to only include ffi in the Gemfile on Ruby >= 3.0.

That seems fine to me.

@tenderlove
Copy link
Member

@dependabot rebase

Bumps [ffi](https://github.com/ffi/ffi) from 1.16.3 to 1.17.1.
- [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md)
- [Commits](ffi/ffi@v1.16.3...v1.17.1)

---
updated-dependencies:
- dependency-name: ffi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/gemfiles/2.7/ffi-1.17.1 branch from fb7258c to 78f0191 Compare January 8, 2025 20:31
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 8, 2025

Looks like ffi is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Jan 8, 2025
@dependabot dependabot bot deleted the dependabot/bundler/gemfiles/2.7/ffi-1.17.1 branch January 8, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants