Skip to content

Reject pattern match with unexpected double splat inside array #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eileencodes merged 1 commit into from
Jan 8, 2025
Merged

Reject pattern match with unexpected double splat inside array #3382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/prism.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20520,12 +20520,13 @@ parse_expression_prefix(pm_parser_t *parser, pm_binding_power_t binding_power, b
return (pm_node_t *) node;
}
case PM_TOKEN_UMINUS_NUM: {
pm_token_t prev = parser->previous;
parser_lex(parser);

pm_token_t operator = parser->previous;
pm_node_t *node = parse_expression(parser, pm_binding_powers[parser->previous.type].right, false, false, PM_ERR_UNARY_RECEIVER, (uint16_t) (depth + 1));

if (accept1(parser, PM_TOKEN_STAR_STAR)) {
if ((prev.type != PM_TOKEN_BRACKET_LEFT_ARRAY) && (accept1(parser, PM_TOKEN_STAR_STAR))) {
pm_token_t exponent_operator = parser->previous;
pm_node_t *exponent = parse_expression(parser, pm_binding_powers[exponent_operator.type].right, false, false, PM_ERR_EXPECT_ARGUMENT, (uint16_t) (depth + 1));
node = (pm_node_t *) pm_call_node_binary_create(parser, node, &exponent_operator, exponent, 0);
Expand Down
14 changes: 14 additions & 0 deletions test/prism/errors/pattern_match_with_unexpected_splat_inside_arraytxt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
a => [-2*b]
^ expected a `]` to close the pattern expression
^ unexpected '*', expecting end-of-input
^ unexpected '*', ignoring it
^ unexpected ']', expecting end-of-input
^ unexpected ']', ignoring it

a => [-2**b]
^ expected a `]` to close the pattern expression
^~ unexpected '**', expecting end-of-input
^~ unexpected '**', ignoring it
^ unexpected ']', expecting end-of-input
^ unexpected ']', ignoring it

Loading