Fix parser translator when unescaping invalid utf8 #3401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
Jan 12, 2025
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Could you add this to the polyfills directory? We already have one for byteindex and one for unpack1, so may as well add another one here
1. The string starts out as binary 2. `ち` is appended, forcing it back into utf-8 3. Some invalid byte sequences are tried to append > incompatible character encodings: UTF-8 and BINARY (ASCII-8BIT) This makes use of my wish to use `append_as_bytes`. Unfortunatly that method is rather new so it needs a fallback
Earlopain
force-pushed
the
parser-translator-escaping-invalid-utf8
branch
from
9999ef2 to
e31e94a
Compare
Collaborator
Author
|
Works for me, didn't know that was a thing. I really appreciate how fast you're getting to these. Thanks! |
kddnewton
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ちis appended, forcing it back into utf-8This makes use of my wish to use
append_as_bytes. Unfortunatly that method is rather new so it needs a fallback.It's for #2539. Since ruby-spec has some rather odd-looking code it runs into it.