Skip to content

Fix block parameters and it for RubyParser #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kddnewton merged 1 commit into from
Jan 14, 2025
Merged

Fix block parameters and it for RubyParser #3409

kddnewton merged 1 commit into from
Jan 14, 2025

Conversation

@presidentbeef
Copy link
Contributor

@presidentbeef presidentbeef commented Jan 14, 2025

Testing with x { it } :

Before:

RubyParser:

s(:iter, s(:call, nil, :x), 0, s(:call, nil, :it))

Prism:

s(:iter, s(:call, nil, :x), [], s(:call, nil, :it))

After:

RubyParser:

s(:iter, s(:call, nil, :x), 0, s(:call, nil, :it))

Prism:

s(:iter, s(:call, nil, :x), 0, s(:call, nil, :it))

@presidentbeef presidentbeef mentioned this pull request Jan 14, 2025
Closed
@kddnewton kddnewton merged commit 31009d8 into ruby:main Jan 14, 2025
57 checks passed
@presidentbeef presidentbeef changed the title Fix block paremeters and it for RubyParser Fix block parameters and it for RubyParser Jan 14, 2025
@presidentbeef presidentbeef mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@presidentbeef @kddnewton