Further refine string handling in the parser translator #3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly around newlines and line continuation. * percent arrays need special backslash handling in the ast * Fix offset issue for heredocs with many line continuations (used wrong variable as index access) * More refined rules on when to simplify string tokens * Handle line continuations in squiggly heredocs * Correctly dedent squiggly heredocs with interpolation * Consider `':foo:` and `%s[foo]` to not be interpolation
Earlopain
force-pushed
the
parser-translator-better-strings
branch
from
d1697b3 to
4edfe9d
Compare
kddnewton
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly around newlines and line continuation.
':foo:and%s[foo]to not be interpolationAppologies for the amount of stuff
I sincerely hope this is the last of it for string handling. I'm not particularly proud of how this code evolved over the last PRs. It seems to handle a large chunk correctly and there are now an appropriate amount of tests so I might come back and try to clean it up a bit in the future.
#2539 can now be closed. All reported problems are now resolved, with this PR removing the last wrong offense from RuboCop for
ruby-spec.