Allow to test a custom fixtures path during testing #3417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
Jan 17, 2025
test/prism/snapshots_test.rb
Outdated
| # matches the snapshot. | ||
| assert_equal(saved, printed) | ||
| else | ||
| elsif !Fixture.custom_base_path? |
Collaborator
There was a problem hiding this comment.
Can you change this to just skip this whole test if there's a custom base path? I found it confusing to have this case in here.
Something like return if Fixture.custom_base_path? at the top after the test helper require would probably work.
Collaborator
Author
There was a problem hiding this comment.
Agreed, that's cleaner
Earlopain
force-pushed
the
tests-custom-fixtures
branch
from
8a46052 to
9b322b0
Compare
Of course, these won't really be fixtures, but it allows to test against whole codebases without copying them, doing symlinks or something like that. For example, I can tell that over the whole RuboCop codebase, there are only 8 files that produce mismatched ast. Telling what the problem is is a different problem. The ast for real files can and will be huge so I haven't checked yet (maybe parser bug) but it's nice for discoverability regardless
Earlopain
force-pushed
the
tests-custom-fixtures
branch
from
9b322b0 to
2184d82
Compare
kddnewton
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course, these won't really be fixtures, but it allows to test against whole codebases without copying them, doing symlinks or something like that.
For example, I can tell that over the whole RuboCop codebase, there are only 8 files that produce mismatched ast. Telling what the problem is is a different problem. The ast for real files can and will be huge so I haven't checked (maybe parser bug) but it's nice for discoverability regardless