Fix parser translator ast for regex with fake newlines #3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These newlines are preserved, so in prism they will not create an extra line in the unescaped content. Additionally, apply the same logic to interpolated regex nodes
kddnewton
requested changes
Jan 20, 2025
| .each do |lines| | ||
| escaped_lengths << lines.sum(&:bytesize) | ||
| unescaped_lines_count = lines.sum do |line| | ||
| next 0 if regex # Will always be preserved as is |
Collaborator
There was a problem hiding this comment.
Can we put this if statement around the map here instead of checking each time?
kddnewton
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These newlines are preserved, so in prism they will not create an extra line in the unescaped content.
Additionally, apply the same logic to interpolated regex nodes.