Skip to content

Only unnest parser mlhs nodes when no rest argument is provided #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kddnewton merged 1 commit into from
Jan 20, 2025
Merged

Only unnest parser mlhs nodes when no rest argument is provided #3430

kddnewton merged 1 commit into from
Jan 20, 2025

Conversation

@Earlopain
Copy link
Collaborator

@Earlopain Earlopain commented Jan 20, 2025 

(a,), = []

PARSER====================
s(:masgn,
  s(:mlhs,
    s(:mlhs,
      s(:lvasgn, :a))),
  s(:array))
PRISM====================
s(:masgn,
  s(:mlhs,
    s(:lvasgn, :a)),
  s(:array))

@Earlopain
Only unnest parser mlhs nodes when no rest argument is provided
8aa1f46 
```
(a,), = []

PARSER====================
s(:masgn,
  s(:mlhs,
    s(:mlhs,
      s(:lvasgn, :a))),
  s(:array))
PRISM====================
s(:masgn,
  s(:mlhs,
    s(:lvasgn, :a)),
  s(:array))
```
@kddnewton kddnewton merged commit 4afe194 into ruby:main Jan 20, 2025
57 checks passed
@Earlopain Earlopain deleted the parser-translator-mlhs-simplify branch January 20, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Earlopain @kddnewton