Skip to content

[Bug #21345] Fix accepting multiple rest patterns with leading match#3564

Merged
eileencodes merged 1 commit intoruby:mainfrom
Earlopain:implicit-rest-leading
Jul 16, 2025
Merged

[Bug #21345] Fix accepting multiple rest patterns with leading match#3564
eileencodes merged 1 commit intoruby:mainfrom
Earlopain:implicit-rest-leading

Conversation

@Earlopain
Copy link
Collaborator

@Earlopain Earlopain commented May 19, 2025

@Earlopain Earlopain force-pushed the implicit-rest-leading branch from 3020fe9 to 587867d Compare May 19, 2025 11:15
@Earlopain
Copy link
Collaborator Author

Openend https://bugs.ruby-lang.org/issues/21352 for valgrind

@mame mame requested a review from kddnewton June 3, 2025 07:36
@Earlopain Earlopain force-pushed the implicit-rest-leading branch from 587867d to de56fa4 Compare June 30, 2025 12:56
@rafaelfranca rafaelfranca added the Need another review Need an extra review label Jul 16, 2025
@rafaelfranca
Copy link
Collaborator

Code is correct, but as this also closes a bug in the ruby issue tracker, and I don't know if that requires us to commit to Ruby, I'm not going to merge. @tenderlove @eileencodes what is the process here?

@eileencodes eileencodes merged commit 3ca1bbc into ruby:main Jul 16, 2025
56 checks passed
@eileencodes
Copy link
Member

It will sync to Ruby so it's fine to merge here.

@Earlopain Earlopain deleted the implicit-rest-leading branch October 3, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Need another review Need an extra review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants