Conversation
Earlopain
force-pushed
the
parser-translator-escape-invalid-encoding
branch
from
154ed98 to
1bcf087
Compare
Collaborator
Author
|
Right, no |
7 tasks
kddnewton
reviewed
Jun 11, 2025
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Let's use scan_byte and add a polyfill for when it's necessary
Earlopain
force-pushed
the
parser-translator-escape-invalid-encoding
branch
from
1bcf087 to
f2a2ebc
Compare
Instead, prefer `scan_byte` over `get_byte` since that already returns the byte as an integer, sidestepping conversion issues. Fixes ruby#3582
Earlopain
force-pushed
the
parser-translator-escape-invalid-encoding
branch
from
f2a2ebc to
7f3008b
Compare
Collaborator
Author
|
Right, makes sense. I changed it. |
kddnewton
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
byte.ordcan raise when it is not valid in its encoding. Instead, preferscan_byteoverget_bytesince that already returns the byte as an integer, sidestepping conversion issues.Fixes #3582