Add OS matrix to Rust build and upgrade bindgen#3594
Merged
tenderlove merged 5 commits intoruby:mainfrom Jul 18, 2025
Merged
Conversation
vinistock
force-pushed
the
vs_fix_windows_build
branch
7 times, most recently
from
a4babe5 to
fe820bb
Compare
vinistock
force-pushed
the
vs_fix_windows_build
branch
from
fe820bb to
ab22c39
Compare
vinistock
force-pushed
the
vs_fix_windows_build
branch
from
cd8bb9c to
3251900
Compare
rafaelfranca
approved these changes
Jul 16, 2025
vinistock
added a commit
to Shopify/rubydex
that referenced
this pull request
Nov 20, 2025
Closes #68 It seems that ruby/prism#3594 _did_ fix the Windows build 🎉. This PR re-enables it so that we don't accidentally add Windows incompatible code. Most of the fixes are related to assuming forward slashes in file paths or not accounting for the carriage return character where it may happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling the Rust crate fails on Windows while generating bindings at the moment. I want to try to upgrade
bindgento the latest version to see if the issue has been fixed.Also, this PR adds an OS matrix to the Rust builds, so that we can catch build issues sooner. This PR is easier to review by commit.
Notes:
wasm32-wasitarget has been renamed towasm32-wasip1