Refine signature of Numeric#step and add type of Enumerator::ArithmeticSequence#2600
Merged
ksss merged 1 commit intoruby:masterfrom Aug 10, 2025
Merged
Refine signature of Numeric#step and add type of Enumerator::ArithmeticSequence#2600ksss merged 1 commit intoruby:masterfrom
Numeric#step and add type of Enumerator::ArithmeticSequence#2600ksss merged 1 commit intoruby:masterfrom
Conversation
And add type of `Enumerator::ArithmeticSequence`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several mistakes in the type of the
#stepmethod.Problem
Mistakes in block variable type
The one of
Integer#stepoverload is here.(Numeric limit, ?Integer step) { (Integer) -> void } -> voidBut,
iisFloatin following code.Return type without block
In ruby, the method that returns
Enumerator::ArithmeticSequencebut signature returnsEnumeratortype.Documentation
When hovering over
1.stepin Steep, I cannot read the rdoc in LSP.Solution
Add type of
Enumerator::ArithmeticSequenceReturn
Enumerator::ArithmeticSequenceto match the actual behavior.Enumerator::ArithmeticSequenceintroduced from ruby v2.6.We will be able to type
Enumerator::ArithmeticSequencespecific methods.Notes
The
Enumerator::ArithmeticSequenceholds several values.However, the Ruby specification is more complex than expected.
The use of
Enumerator::ArithmeticSequenceis limited, and since there haven't been any requests for it so far, I don't think there's a need to make it overly complex.Unify signatures to
Numeric#stepIt is possible to copy the documentation, but if the goal is to keep it simple, unifying it under
Numeric#stepwould make it easier to manage.