Skip to content

Fix darkfish responsiveness issue on screens between 1024px and ~1650px #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Fix darkfish responsiveness issue on screens between 1024px and ~1650px #1148

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c15320e
Fix darkfish responsiveness issue on screens between 1024px and ~1650px
st0012 Aug 4, 2024
c1535cd
Fix footer display
st0012 Aug 4, 2024
9a8ae3e
Use css variable to declare sidebar's width
st0012 Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions lib/rdoc/generator/template/darkfish/css/rdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,16 +214,10 @@ nav {
background: white;
}

@media (min-width: 1024px) {
nav {
min-height: unset;
height: calc(100vh - 100px); /* reduce the footer height */
}
}

main {
display: block;
margin: 3em 1em 1em;
margin: 3em auto 1em;
padding: 0 1em; /* Add padding to keep space between main content and sidebar/right side of the screen */
min-width: 340px;
font-size: 16px;
width: 100%;
Expand All @@ -232,8 +226,7 @@ main {

@media (min-width: 1024px) {
main {
margin-left: auto;
margin-right: auto;
margin-left: 300px;
}
}

Expand Down Expand Up @@ -731,4 +724,8 @@ pre {
font-family: "Source Code Pro", Monaco, monospace;
}

footer {
z-index: 20;
}

/* @end */