Skip to content

Prefer String#ord to String#codepoints[0] #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Prefer String#ord to String#codepoints[0] #1220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/rdoc/code_object/method_attr.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ def <=>(other)
return unless other.respond_to?(:singleton) &&
other.respond_to?(:name)

[@singleton ? 0 : 1, name_codepoint_range, name] <=>
[other.singleton ? 0 : 1, other.name_codepoint_range, other.name]
[@singleton ? 0 : 1, name_ord_range, name] <=>
[other.singleton ? 0 : 1, other.name_ord_range, other.name]
end

def == other # :nodoc:
Expand Down Expand Up @@ -415,8 +415,8 @@ def to_s # :nodoc:
end
end

def name_codepoint_range # :nodoc:
case name.codepoints[0]
def name_ord_range # :nodoc:
case name.ord
when 0..64 # anything below "A"
1
when 91..96 # the symbols between "Z" and "a"
Expand Down