Explicitly require helper in test_case #1297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rdoc with
|
| Latest commit: |
defcd3c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6793a53.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://improve-test-setup.rdoc-6cd.pages.dev |
st0012
force-pushed
the
improve-test-setup
branch
from
992b77b to
b36133a
Compare
Currently, the helper is required through the Rake test task, which is very implicit and means when running some tests directly some methods are not available. This commit makes the test case always require the helper and remove the related options from the Rake test task.
st0012
force-pushed
the
improve-test-setup
branch
from
b36133a to
defcd3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the helper is required through the Rake test task, which is very implicit and means when running some tests directly some methods are not available.
For example, running
bundle exec ruby -Itest PATH_TO_RDOC/test/rdoc/test_rdoc_comment.rbwill triggerNoMethodError: undefined method 'assert_linear_performance' for an instance of RDocCommentTestbecausetest/lib/helper.rbis not required.This commit makes the test case always require the helper and remove the related options from the Rake test task.