Move default RDoc headings to a constant #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
approved these changes
Apr 21, 2025
vinistock
force-pushed
the
vs-make-to-rdoc-headings-more-idiomatic
branch
from
72d2bc2 to
1891829
Compare
vinistock
force-pushed
the
vs-make-to-rdoc-headings-more-idiomatic
branch
from
1891829 to
2c151c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the heading values one by one, we can simply initialize the hash straight away. And since the default values never change, we can use a constant to define them and dup in case they have to be modified by the instance.