Added gemspec file to gem package #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rdoc with
|
| Latest commit: |
783adb8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://114ce238.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://add-gemspec-to-package.rdoc-6cd.pages.dev |
|
🚀 Preview deployment available at: https://114ce238.rdoc-6cd.pages.dev (commit: 783adb8) |
|
I'm checking this change will fix to install the broken gemspec with the current Ruby HEAD. |
kou
reviewed
Jun 18, 2025
rdoc.gemspec
Outdated
| # for ruby core repository. It was generated by | ||
| # `git ls-files -z`.split("\x0").each {|f| puts " #{f.dump}," unless f.start_with?(*%W[test/ spec/ features/ .]) } | ||
| non_lib_files = [ | ||
| "rdoc.gemspec", |
There was a problem hiding this comment.
Could you keep this list in alphabetical order?
The original gemspec need to install rdoc as bundled gems at the official Ruby package. Fix https://bugs.ruby-lang.org/issues/21312
hsbt
force-pushed
the
add-gemspec-to-package
branch
from
973f2f7 to
8ba6333
Compare
|
I'm investigating another issue for |
The current glob pattern caused to issue with Ruby package installation.
```
/Users/hsbt/Documents/github.com/ruby/ruby/lib/fileutils.rb:1625:in 'File.stat': No such file or directory @ rb_file_s_stat - /Users/hsbt/Documents/github.com/ruby/ruby/.bundle/gems/rdoc-6.14.0/lib/English.rb (Errno::ENOENT)
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/fileutils.rb:1625:in 'block in FileUtils#install'
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/fileutils.rb:2471:in 'block in FileUtils#fu_each_src_dest'
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/fileutils.rb:2487:in 'FileUtils#fu_each_src_dest0'
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/fileutils.rb:2469:in 'FileUtils#fu_each_src_dest'
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/fileutils.rb:1624:in 'FileUtils#install'
from ./tool/rbinstall.rb:216:in 'Object#install'
from ./tool/rbinstall.rb:694:in 'block in RbInstall::DirPackage#extract_files'
from ./tool/rbinstall.rb:689:in 'Array#each'
from ./tool/rbinstall.rb:689:in 'RbInstall::DirPackage#extract_files'
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/rubygems/installer.rb:853:in 'Gem::Installer#extract_files'
from /Users/hsbt/Documents/github.com/ruby/ruby/lib/rubygems/installer.rb:312:in 'Gem::Installer#install'
from ./tool/rbinstall.rb:746:in 'block in RbInstall::UnpackedInstaller#install'
from ./tool/rbinstall.rb:534:in 'RbInstall.no_write'
from ./tool/rbinstall.rb:746:in 'RbInstall::UnpackedInstaller#install'
from ./tool/rbinstall.rb:1174:in 'block (2 levels) in <main>'
from ./tool/rbinstall.rb:1138:in 'IO.foreach'
from ./tool/rbinstall.rb:1138:in 'block in <main>'
from ./tool/rbinstall.rb:1224:in 'block in <main>'
from ./tool/rbinstall.rb:1221:in 'Array#each'
from ./tool/rbinstall.rb:1221:in '<main>'
```
hsbt
force-pushed
the
add-gemspec-to-package
branch
from
8ba6333 to
e89d2b8
Compare
kou
reviewed
Jun 18, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
|
I confirmed 783adb8 is working fine with |
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Jun 18, 2025
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Jun 18, 2025
|
Thank you for fixing this @hsbt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
gemspecneed to installrdocas bundled gems at the official Ruby package.Fix https://bugs.ruby-lang.org/issues/21312