Fix backslash in RDoc monofont causing unwanted linking #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When text in <tt> tags contains backslashes (e.g., <tt>.bar.hello(\)</tt>), RDoc was incorrectly creating cross-reference links because the backslash matched the escaped character pattern in CROSSREF_REGEXP. This fix adds a check to prevent cross-referencing when the match is solely due to escaped characters that don't represent valid method/class references. Fixes #1390 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
🚀 Preview deployment available at: https://c9148c78.rdoc-6cd.pages.dev (commit: 58b0238) |
|
Sorry for the noise. I ran the wrong claude command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<tt>tags caused unwanted cross-reference linksProblem
When text in
<tt>tags contains backslashes (e.g.,<tt>.bar.hello(\)</tt>), RDoc was incorrectly creating cross-reference links. This happened because the backslash matched the escaped character pattern inCROSSREF_REGEXP, causing the entire string to be processed as a potential cross-reference.Solution
Added checks in both
handle_regexp_CROSSREFandconvert_flowto detect when a match is solely due to escaped character patterns that don't represent valid method/class references. These strings are now rendered as code without creating links.Test plan
test_convert_CROSSREF_backslash_escapes_in_monofontto verify the fixFixes #1390
🤖 Generated with Claude Code