Skip to content

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 16, 2025

  • Added Herb LSP to suggested VS Code extension, which will surface ERB/HTML issues in .rthml templates.
  • Fixed all surfaced issues
  • Added ERB lint step on CI

@st0012 st0012 added the bug label Oct 16, 2025
@matzbot
Copy link
Collaborator

matzbot commented Oct 16, 2025

🚀 Preview deployment available at: https://e85c8668.rdoc-6cd.pages.dev (commit: bb5f1c5)

@marcoroth
Copy link

FWIW, I think you could run npx @herb-tools/linter "**/*.rhtml" since the linter CLI accepts a glob pattern.

@st0012 st0012 changed the title Add missing HTML tags Add Herb linter and fix HTML and ERB linting issues Oct 16, 2025
@st0012
Copy link
Member Author

st0012 commented Oct 16, 2025

@marcoroth Thanks! I've updated the PR to just use the linter

@st0012
Copy link
Member Author

st0012 commented Oct 20, 2025

Tests are failing because of various unrelated reasons 💀
Merging this one first. Thanks again @marcoroth

@st0012 st0012 merged commit 0260ac8 into master Oct 20, 2025
56 of 62 checks passed
@st0012 st0012 deleted the fix-html-tags branch October 20, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants