Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented Oct 7, 2024

Sorry for the many small PRs, just realized this needs to be updated as well.

@maximecb
Copy link
Contributor

maximecb commented Oct 7, 2024

Since lots of small things need to be updated

Do you think you could add an automated test?
Quickly run one benchmark to produce data and then try to run this script?

@eregon
Copy link
Member Author

eregon commented Oct 7, 2024

Added, let's see if it works there.
It might not because e.g. --graph needs ImageMagick to be installed.

@eregon
Copy link
Member Author

eregon commented Oct 7, 2024

The test works now

@maximecb maximecb merged commit fb25c3c into ruby:main Oct 7, 2024
4 checks passed
@eregon eregon deleted the patch-3 branch October 7, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants