Skip to content

Fix value reported by get_maxrss on macos #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix value reported by get_maxrss on macos #344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceda5f1
Fix value reported by get_maxrss on macos
Nov 12, 2024
f8a1181
Update harness/harness-common.rb
maximecb Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion harness/harness-common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ def get_rss
end
end

def is_macos
RUBY_PLATFORM.match?(/darwin/)
end

def get_maxrss
require 'fiddle'
require 'rbconfig/sizeof'
Expand All @@ -70,7 +74,14 @@ def get_maxrss
result = getrusage.call(rusage_self, buffer)
raise unless result.zero?
maxrss_kb = buffer[offset, Fiddle::SIZEOF_LONG].unpack1('q')
1024 * maxrss_kb

# On macos, this value is already in bytes
# (and the manpage is wrong)
if is_macos
maxrss_kb
else
1024 * maxrss_kb
end
rescue LoadError
warn "Failed to get max RSS: #{$!.message}"
nil
Expand Down
Loading