Skip to content

Conversation

@byroot
Copy link
Member

@byroot byroot commented Feb 11, 2025

Fix: #358

Before:

inline_code_size:    6,752,176
outlined_code_size:  2,067,600
code_region_size:    17,268,736
yjit_alloc_size:     25,934,245
yjit_compile_time:    989.69ms
RSS: 393.7MiB
MAXRSS: 393.9MiB
Average of last 15, non-warmup iters: 299ms
Total time spent benchmarking: 27s

interp: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [arm64-darwin23]
yjit: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23]

--------  -----------  ----------  ---------  ----------  ------------  -----------
bench     interp (ms)  stddev (%)  yjit (ms)  stddev (%)  yjit 1st itr  interp/yjit
lobsters  463.9        1.3         299.8      2.6         0.563         1.547
--------  -----------  ----------  ---------  ----------  ------------  -----------

After:

inline_code_size:    6,808,680
outlined_code_size:  2,178,968
code_region_size:    17,448,960
yjit_alloc_size:     26,006,453
yjit_compile_time:    978.48ms
RSS: 380.1MiB
MAXRSS: 380.3MiB
Average of last 16, non-warmup iters: 296ms
Total time spent benchmarking: 27s

interp: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [arm64-darwin23]
yjit: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23]

--------  -----------  ----------  ---------  ----------  ------------  -----------
bench     interp (ms)  stddev (%)  yjit (ms)  stddev (%)  yjit 1st itr  interp/yjit
lobsters  463.1        1.8         296.3      2.2         0.596         1.563
--------  -----------  ----------  ---------  ----------  ------------  -----------

cc @maximecb @XrXr

Fix: ruby#358

Before:
```
inline_code_size:    6,752,176
outlined_code_size:  2,067,600
code_region_size:    17,268,736
yjit_alloc_size:     25,934,245
yjit_compile_time:    989.69ms
RSS: 393.7MiB
MAXRSS: 393.9MiB
Average of last 15, non-warmup iters: 299ms
Total time spent benchmarking: 27s

interp: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [arm64-darwin23]
yjit: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23]

--------  -----------  ----------  ---------  ----------  ------------  -----------
bench     interp (ms)  stddev (%)  yjit (ms)  stddev (%)  yjit 1st itr  interp/yjit
lobsters  463.9        1.3         299.8      2.6         0.563         1.547
--------  -----------  ----------  ---------  ----------  ------------  -----------
```

After:
```
inline_code_size:    6,808,680
outlined_code_size:  2,178,968
code_region_size:    17,448,960
yjit_alloc_size:     26,006,453
yjit_compile_time:    978.48ms
RSS: 380.1MiB
MAXRSS: 380.3MiB
Average of last 16, non-warmup iters: 296ms
Total time spent benchmarking: 27s

interp: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [arm64-darwin23]
yjit: ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin23]

--------  -----------  ----------  ---------  ----------  ------------  -----------
bench     interp (ms)  stddev (%)  yjit (ms)  stddev (%)  yjit 1st itr  interp/yjit
lobsters  463.1        1.8         296.3      2.2         0.596         1.563
--------  -----------  ----------  ---------  ----------  ------------  -----------
```
@byroot byroot force-pushed the update-rails-lobsters branch from b1d4eaa to 77294f3 Compare February 11, 2025 20:00
@byroot byroot changed the title Update lobsters bemnchmark to Rails 8.0 Update lobsters benchmark to Rails 8.0 Feb 11, 2025
Copy link
Member

@XrXr XrXr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jean ❤️

@maximecb
Copy link
Contributor

Thank you Jean :) 🙏

@maximecb maximecb merged commit b5b07f8 into ruby:main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants