Add shipit-engine benchmark #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Jul 2, 2025
casperisfine
force-pushed
the
shipit-bench
branch
2 times, most recently
from
d848473 to
9083878
Compare
Shipit is very a vanilla Rails app, with class ERB templates and a fairly common, Active Model Serializers based JSON API. In addition, it supports sqlite3 natively and is jept up to date with Rails, making it a good candidate for benchmarking.
casperisfine
force-pushed
the
shipit-bench
branch
from
9083878 to
977bcad
Compare
casperisfine
commented
Jul 3, 2025
| - ruby: head | ||
| - ruby: truffleruby | ||
| skip: protoboeuf-encode | ||
| skip: protoboeuf-encode shipit |
There was a problem hiding this comment.
I had to skip truffle because apparently pty doesn't work on it?
Gem Load Error is: cannot load such file -- pty
There was a problem hiding this comment.
Ah, it's indeed documented as not implemented: https://github.com/oracle/truffleruby/blob/c762d0ffdd1c66ee02ccc3af0c684f7cde665ade/doc/user/compatibility.md#standard-libraries
k0kubun
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipit is very a vanilla Rails app, with class ERB templates and a fairly common, Active Model Serializers based JSON API.
In addition, it supports sqlite3 natively and is jept up to date with Rails, making it a good candidate for benchmarking.
I also ran it through vernier to make sure it isn't doing anything weird, and it's a very vanilla Rails app profile: