Remove bootsnap from shipit #376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was stuck with this LoadError while psych is of course installed. It went away when I disabled bootsnap.
Because we run crashy Ruby implementations on yjit-bench, I think we can't expect bootstrap to do cache invalidation properly when it could crash in the middle of it. ISEQ caching is also something you'd like to disable and rule out its possibility of causing bugs when debugging a Ruby implementation. So I want to avoid using bootsnap in yjit-bench.