Let the Rails logger print backtraces #380
Merged
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Rails app benchmarks to avoid suppressing error backtraces by using the default
STDOUTlogger withlog_level = :errorinstead of anillogger.It still prints nothing when you run a working Ruby implementation, but prints error backtraces when it has a bug that leads to exceptions. Since yjit-bench is a place where we often encounter new bugs in JITs, we should be able to see backtraces without modifying the source code.