Fix LoadError and warnings for fiddle #383
Merged
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes LoadError and warnings coming from loading
fiddleon benchmarks with Gemfile.While #368 was enough to fix LoadError for benchmarks without Gemfile, it wasn't for ones with Gemfile.
Before
Ruby 3.4
Ruby 3.5
After
Ruby 3.4
Ruby 3.5
Why force_activate
At this point, it doesn't seem like a good idea to rely on
fiddlein the default harness, which is no longer a standard library. However, a procfs alternative (VmHWMin)/proc/$pid/statusis not only inaccurate but also unavailable for macOS. So there's a reason to keep relying onru_maxrssofgetrusage, which seems impossible to call using only stdlib.While it's possible to just add
fiddleto every single benchmark with Gemfile, I don't want to spend effort making sure every new benchmark addsfiddleto the Gemfile.So I want to go with this PR until it stops working. When
fiddleis removed from bundled gems, we'd have to add it to every Gemfile though.