Skip to content

Only use setarch command if it can be used successfully #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

Only use setarch command if it can be used successfully #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions run_benchmarks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,16 @@ def sort_benchmarks(bench_names)
headline_names.sort + other_names.sort + micro_names.sort
end

def setarch_prefix
# Disable address space randomization (for determinism)
prefix = ["setarch", `uname -m`.strip, "-R"]

# Abort if we don't have permission (perhaps in a docker container).
return [] unless system(*prefix, "true")

prefix
end

# Run all the benchmarks and record execution times
def run_benchmarks(ruby:, ruby_description:, categories:, name_filters:, out_path:, harness:, pre_init:, no_pinning:)
bench_data = {}
Expand Down Expand Up @@ -255,8 +265,7 @@ def run_benchmarks(ruby:, ruby_description:, categories:, name_filters:, out_pat
# Set up the benchmarking command
cmd = []
if os == :linux
# Disable address space randomization (for determinism)
cmd += ["setarch", `uname -m`.strip, "-R"]
cmd += setarch_prefix

# Pin the process to one given core to improve caching and reduce variance on CRuby
# Other Rubies need to use multiple cores, e.g., for JIT threads
Expand Down
Loading