Add microbenchmarks for more kinds of sends #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
changed the title
jacob-shops
reviewed
Oct 20, 2025
jacob-shops
reviewed
Oct 20, 2025
jacob-shops
approved these changes
Oct 20, 2025
tenderworks
reviewed
Oct 20, 2025
| run_benchmark(500) do | ||
| 2_000_000.times do |i| | ||
| zero | ||
| one 123 |
There was a problem hiding this comment.
Should we manually unroll this loop somewhat? I'm kind of concerned this benchmark will spend a significant amount of time dealing with the block entry (for the times method) rather than exercising the define_method method calls.
There was a problem hiding this comment.
Oh, that's reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.