Use bundle install --target-rbconfig to install gems for Wasm target
#490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/bundle-install-target-rbconfig
branch
2 times, most recently
from
72a766b to
99535c5
Compare
kateinoigakukun
force-pushed
the
katei/bundle-install-target-rbconfig
branch
2 times, most recently
from
e4ba94f to
0b66668
Compare
This helps investigate test failures
In this way, we can avoid the need to specify `BUNDLE_BUILD__JS=--enable-component-model` when running `bundle install` for the `js` gem. When running `bundle install`, it's usually dynamic-linking enabled, so it makes sense to enable the component model by default.
The ruby-head-wasm-wasi's Gemfile uses vendor/cache to install js gem but the cache gem is not yet available at setup-time. And also with cache gem, the Gemfile is not needed to be installed at setup-time. So just skip the Gemfile installation here
kateinoigakukun
force-pushed
the
katei/bundle-install-target-rbconfig
branch
from
049195e to
4d8d2a8
Compare
beause it requires gems listed in the Gemfile to be installed
to integrate with Bundler in-process
Seems like extension build process is confused by the presence of /usr/local/include/ruby/config.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.