Add logger as a dependency
#597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`logger` will be a bundled gem from Ruby 3.5. https://bugs.ruby-lang.org/issues/20309 So if we use `logger` as the standard library, Bundler shows the following warning. ``` $ bundle exec rbwasm build -o ruby.wasm /3.4.1/lib/ruby/gems/3.4.0/gems/ruby_wasm-2.7.1-x86_64-linux/lib/ruby_wasm.rb:1: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. ``` This PR adds the `logger` to runtime dependency to fix the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loggerwill be a bundled gem from Ruby 3.5.https://bugs.ruby-lang.org/issues/20309
So if we use
loggeras the standard library, Bundler shows the following warning.This PR adds the
loggerto runtime dependency to fix the warning.