Rust gems should install if extension is extconf.rb and not Cargo.toml. #7695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix: #7693 |
|
@gl-yziquel Thanks for this 🙏. It seems #7610 is also fixing the same problem, but in a more robust way, so let's close this PR in favor of #7610. Feel free to leave any comments in there 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Try to install a rust gem scaffolded with bundle gem --ext=rust.
What is your fix for the problem, implemented in this PR?
This is a quick fix. I do not expect it to be merged as is.
I fixed the templating of the gemspec file to refer to extconf.rb instead of Cargo.toml.
I'm not sure it is the right way to proceed. Would appreciate advice or feedback.