Fix bundler/inline failing in Ruby 3.2 due to conflicting securerandom versions
#7984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
deivid-rodriguez
force-pushed
the
vendor-secure-random
branch
from
6616bf9 to
a2e0f1b
Compare
Co-authored-by: Jean Boussier <[email protected]>
It is loaded by `Fetcher` so in most case it's fine. But if using `bundler/inline` and a gem need to be fetched, `securerandom` will be loaded and cause a conflict. Can be reproduced with: ```ruby require 'bundler/inline' gemfile do source 'https://rubygems.org' gem 'graphql', '~> 2.0' gem 'graphql-client', '~> 0.18' end require 'json' require 'graphql/client' require 'graphql/client/http' ``` Ref: rails/rails#52473 (comment) Co-authored-by: Jean Boussier <[email protected]>
deivid-rodriguez
force-pushed
the
vendor-secure-random
branch
from
a2e0f1b to
da76c25
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 17, 2024
Fix `bundler/inline` failing in Ruby 3.2 due to conflicting `securerandom` versions (cherry picked from commit cf33207)
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 17, 2024
Fix `bundler/inline` failing in Ruby 3.2 due to conflicting `securerandom` versions (cherry picked from commit cf33207)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In Ruby 3.2, when using
bundler/inline, BundlerFetcherwill internally activate the default version ofsecurerandom(0.2.2). If the inline gemfile is using a different version ofsecurerandom, and activation conflict will be raised.See #7930.
What is your fix for the problem, implemented in this PR?
In the future we believe the ideal solution is to have
bundler/inlinereexec the original process once the install is done. However, re-exec'ing with original Ruby arguments is tricky, so for now we're vendoringsecurerandomin Bundler to skip this particular problem.Make sure the following tasks are checked