Skip to content

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Dec 13, 2024

What was the end-user or developer problem that led to this PR?

The next version of RDoc introduced rubygems_plugin.rb. But the current test case is broken with that feature. I added condition for new RDoc::RubyGemsHook and the current classes.

Also see ruby/rdoc#1171 and ruby/ruby#12330

/cc @deivid-rodriguez

Make sure the following tasks are checked

@hsbt hsbt force-pushed the support-next-version-of-rdoc branch from a760d25 to 167b713 Compare December 13, 2024 08:20
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I think this is a great move!

@deivid-rodriguez deivid-rodriguez merged commit 66510a0 into master Dec 13, 2024
75 checks passed
@deivid-rodriguez deivid-rodriguez deleted the support-next-version-of-rdoc branch December 13, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants