Update Fiber specs for Ruby 3.1 #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.0 had a fiber extension that added a few extra methods to the Fiber class, even though these methods were implemented in the core: * https://github.com/ruby/ruby/blob/ruby_3_0/ext/fiber/fiber.c * https://github.com/ruby/ruby/blob/ruby_3_0/cont.c#L3122 Ruby 3.1 added these methods to the core, removing the need to require fiber: * https://github.com/ruby/ruby/blob/ruby_3_1/cont.c#L3262 Since these methods are now part of the core, the specs should move to the core too. The resume_spec is a bit of an outlier, this one existed both in core/fiber and library/fiber, where the library one had an additional dependency on Fiber#transfer (defined in the ext). These two files have been merged.
These are ignored since Ruby 3.1.
We don't require fiber anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short version: Ruby 3.0 had a fiber ext that enabled a few extra methods on the Fiber object. The specs for these methods were in library/fiber. Ruby 3.1 has integrated them into the core and made
require 'fiber'a noop.This changes moves the specs from library/fiber into core/fiber.
Related code for Ruby 3.0:
Related code for Ruby 3.1: