Skip to content

Conversation

@herwinw
Copy link
Member

@herwinw herwinw commented May 8, 2025

No description provided.

@herwinw herwinw force-pushed the predefined_dollar_at branch 3 times, most recently from 6cc01c2 to 1c46ccd Compare May 20, 2025 07:38
Copy link
Member

@andrykonchin andrykonchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The only thing I've noticed is in:

-> *backtrace {
      # ...
      $@ = backtrace.first unless backtrace.empty?

the *backtrace parameter may not be a rest one (with *) - it seems it's not used anywhere and a single argument is always passed.

herwinw added 2 commits May 27, 2025 13:21
This can be reused to test assignment of $@
Use the shared specs for Exception#set_backtrace
@herwinw herwinw force-pushed the predefined_dollar_at branch from 1c46ccd to a0e2871 Compare May 27, 2025 11:22
@herwinw
Copy link
Member Author

herwinw commented May 27, 2025

Looks good!

The only thing I've noticed is in:

-> *backtrace {
      # ...
      $@ = backtrace.first unless backtrace.empty?

the *backtrace parameter may not be a rest one (with *) - it seems it's not used anywhere and a single argument is always passed.

I've updated that one, I think this was a leftover of a previous version where I needed to just return the value without updating anything.

@andrykonchin andrykonchin merged commit e0c61b2 into ruby:master May 27, 2025
8 of 11 checks passed
@herwinw herwinw deleted the predefined_dollar_at branch May 27, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants