Cleanups for Data#deconstruct_keys and Struct#deconstruct_keys #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
herwinw
commented
May 28, 2025
herwinw
commented
- Use the correct method name in the description for Data#deconstruct_keys
- Add blank line between Data object creation and specs, to keep this consistent.
- Add spec for incorrect index for Struct#deconstruct_keys, this spec was present for Data#deconstruct_keys, but missing for Struct.
* Use the correct method name in the description for Data#deconstruct_keys * Add blank line between Data object creation and specs, to keep this consistent. * Add spec for incorrect index for Struct#deconstruct_keys, this spec was present for Data#deconstruct_keys, but missing for Struct.
herwinw
force-pushed
the
data_struct_deconstruct_keys
branch
from
1308d72 to
22e1e54
Compare
andrykonchin
approved these changes
May 29, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.