[Ruby 3.2] Add spec for CGI.unescapeURIComponent #1299
Merged
+168
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinistr
force-pushed
the
3.2-cgi-unescape-uri-component
branch
from
f79dc26 to
b7f5ed4
Compare
trinistr
force-pushed
the
3.2-cgi-unescape-uri-component
branch
2 times, most recently
from
6ef66b7 to
4a31292
Compare
trinistr
force-pushed
the
3.2-cgi-unescape-uri-component
branch
from
4a31292 to
bb2afc7
Compare
Member
|
Thank you! |
1 similar comment
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1016
Spec for
.escapeURIComponentwas done in #1080.This is pretty much the spec for
.escapeURIComponentwith reversed inputs and outputs and incorporating fix from 7d8998a. Main difference is thatunescape...does not preserve encoding, instead accepting target encoding as an argument.I also noticed a copy-paste typo in the test for
UnboundMethod#==, creating a separate PR seemed unnecessary .